changelog utility for merging stuff #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashankram
reviewed
Nov 22, 2024
Contributor
There was a problem hiding this comment.
The test fixes look fine. Would you mind updating the PR && changelog description to indicate the effect of the changelog behavior being added and how it was tested. I don't see e2e tests being added for those, so at the very least provide the testing steps in the PR description.
shashankram
approved these changes
Nov 22, 2024
nfuden
pushed a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
midterm update post gloo donation
this also forced a trivy upgrade to the same style used else where.
This pr does 3 things.