ICC Profiles - #16
Merged
Merged
Conversation
Two typos actually, since it lists X >= d and X > d, not X < d
someone13574
added a commit
that referenced
this pull request
Jan 7, 2026
Add parsing support for some icc profiles so that the cmyk conversion is better. This also creates some types for handling colors better instead of as vec3's, and also adds a library for handling buffer reading, since that has been duplicated a bunch. The other code will be moved to the color library and buffer library in separate commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parsing support for some icc profiles so that the cmyk conversion is better. This also creates some types for handling colors better instead of as vec3's, and also adds a library for handling buffer reading, since that has been duplicated a bunch. The other code will be moved to the color library and buffer library in separate commits.
The colors don't match PDF.js's perfectly, but it is good enough for now