feat: support import for sonatyperepo_repository_apt_* resources
#171
Conversation
|
madpah
changed the title
sonatyperepo_repository_apt_* resources
| } else { | ||
| // Set default values when API doesn't provide replication data | ||
| m.Replication = &RepositoryReplicationModel{ | ||
| PreemptivePullEnabled: types.BoolValue(false), |
There was a problem hiding this comment.
Extract false to a common constant and use in schema please @yfougeray-euphoria
| } | ||
|
|
||
| // DoImportRequest implements the import functionality for APT Hosted repositories | ||
| func (f *AptRepositoryFormatHosted) DoImportRequest(repositoryName string, apiClient *sonatyperepo.APIClient, ctx context.Context) (any, *http.Response, error) { |
There was a problem hiding this comment.
Why not call the DoReadRequest function that exists already? This looks like code duplication...
| } | ||
|
|
||
| // DoImportRequest implements the import functionality for APT Proxy repositories | ||
| func (f *AptRepositoryFormatProxy) DoImportRequest(repositoryName string, apiClient *sonatyperepo.APIClient, ctx context.Context) (any, *http.Response, error) { |
There was a problem hiding this comment.
Why not call the DoReadRequest function that exists already? This looks like code duplication...
| } | ||
|
|
||
| // ValidateRepositoryForImport validates that the imported repository is indeed an APT Hosted repository | ||
| func (f *AptRepositoryFormatHosted) ValidateRepositoryForImport(repositoryData any, expectedFormat string, expectedType RepositoryType) error { |
There was a problem hiding this comment.
Can't see ValidateRepositoryForImport being called from anywhere @yfougeray-euphoria ?
| return *apiResponse, httpResponse, nil | ||
| } | ||
|
|
||
| // ValidateRepositoryForImport validates that the imported repository is indeed an APT Proxy repository |
There was a problem hiding this comment.
Can't see ValidateRepositoryForImport being called from anywhere @yfougeray-euphoria ?
2 participants
Resolve #146