sflow: per-port sample rate, direction, and VPP APIs - #263
Merged
ritvikiscool9 merged 1 commit intoJul 20, 2026
Merged
Conversation
Adds three stacked VPP patches: per-port sample rate (0012, with per-thread sampling counters), per-port direction (0013), and the per-interface sampling-rate/direction binary APIs (0014). Signed-off-by: Ritvik Uppal <rituppal@cisco.com>
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
dypet
approved these changes
Jul 20, 2026
dypet
left a comment
dypet
left a comment
Contributor
There was a problem hiding this comment.
LGTM, comments from original PRs have been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three stacked VPP patches: per-port sample rate (0012, with per-thread sampling counters), per-port direction (0013), and the per-interface sampling-rate/direction binary APIs (0014).
The per-interface sample rate PR: #261
The per-interface direction PR: ritvikiscool9#1
The per-interface binary APIs PR: ritvikiscool9#2