MS-05 Device Model Object Validation Util #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Development/nmos/test/control_protocol_utils_test.cpp
lo-simon
requested changes
Nov 10, 2025
Collaborator
lo-simon
left a comment
lo-simon
left a comment
There was a problem hiding this comment.
Just a few minor suggestions, then the rest are good to go.
lo-simon
requested changes
Nov 10, 2025
Co-authored-by: Simon Lo <[email protected]>
lo-simon
requested changes
Nov 10, 2025
lo-simon
requested changes
Nov 13, 2025
Collaborator
lo-simon
left a comment
lo-simon
left a comment
There was a problem hiding this comment.
Update validate_resource comment on header
Co-authored-by: Simon Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that constructed Device Model object has required properties.