Add atomic and chrono to the required components in the CMake file

[lo-simon]

Thank you, @tianzhuqiao and @glance-, for reporting the missing chrono library while building nmos-cpp-node #467. The library has now been added to the list of required components in the nmos-cpp CMake file, which resolves the issue.

[garethsb]

In the original design, these should not always be required, they should be conditional based on meaning of bst::chrono and bst::atomic.

nmos-cpp/Development/slog/all_in_one.h

Line 2989 in 7916232

#ifndef BST_THREAD_BOOST

nmos-cpp/Development/slog/all_in_one.h

Line 931 in 7916232

#ifndef BST_ATOMIC_BOOST

[lo-simon]

In the original design, these should not always be required, they should be conditional based on meaning of bst::chrono and bst::atomic.

nmos-cpp/Development/slog/all_in_one.h

Line 2989 in 7916232

#ifndef BST_THREAD_BOOST

nmos-cpp/Development/slog/all_in_one.h

Line 931 in 7916232

#ifndef BST_ATOMIC_BOOST

Thanks, @garethsb. The latest update has BST_THREAD_BOOST defined in CMake, so we need to include boost::chrono in CMake as well.

nmos-cpp/Development/cmake/NmosCppLibraries.cmake

Line 33 in 7916232

BST_THREAD_BOOST # provide bst::chrono::duration, etc. using either std:: or boost:: symbols

[garethsb]

@lo-simon FWIW, that comment you mentioned in the CMake file is slightly confusing, because it reads as if when that preprocessor symbol is defined, bst:: symbols may be aliases for either boost:: or std::. Whereas in fact it means they will be aliases for boost::.

nmos-cpp/Development/cmake/NmosCppLibraries.cmake

Line 33 in 7916232

BST_THREAD_BOOST # provide bst::chrono::duration, etc. using either std:: or boost:: symbols

It's copied from the relevant (amalgamated) header, bst/chrono.h:

nmos-cpp/Development/slog/all_in_one.h

Line 2986 in 3e8aa68

// Provide bst::chrono::duration, etc. using either std:: or boost:: symbols

There it is explaining that you can control whether the aliases are boost:: (by defining BST_THREAD_BOOST) or std:: (by not defining it). Later headers made this idiom more explicit by always either defining BST_xxx_BOOST or BST_xxx_STD.

E.g.

nmos-cpp/Development/bst/regex.h

Lines 4 to 20 in 3e8aa68

	// Provide bst::regex, etc. using either std:: or boost:: symbols
	#if !defined(BST_REGEX_STD) && !defined(BST_REGEX_BOOST)
	#if defined(__GNUC__)
	#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 9)
	#define BST_REGEX_STD
	#else
	#define BST_REGEX_BOOST
	#endif
	#else
	#define BST_REGEX_STD
	#endif