Conversation
- remove the peerDependencies block and declare @loopback/boot, @loopback/core, @loopback/repository, @loopback/rest and @sourceloop/core as direct dependencies instead - the peer on @sourceloop/core could not be resolved in consumer monorepos where @sourceloop/core is a local workspace package, which made npm error with ERESOLVE and blocked npm audit fix from running - the peer was introduced in 9.1.0; releases up to 9.0.0 declared no peerDependencies at all, which is why the failure appeared only after consumers moved to ^9.1.0 GH-173
1 task
- add an undici ^6.27.0 override so the transitive copy resolves to a patched release instead of the vulnerable one trivy flagged - regenerate package-lock.json to apply the override - verified locally with the same command and config ci uses, trivy fs . --config trivy.yml, which now reports no fixable high or critical findings GH-173
|
Sourav-kashyap
approved these changes
Aug 16, 2026
a-ganguly
approved these changes
Aug 16, 2026
Contributor
|
🎉 This PR is included in version 10.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves
@loopback/*,@sourceloop/core,jsdom,lodash, andtslibfrompeerDependenciestodependenciesinpackage.json, and bumps the pinned versions for these packages:@loopback/boot: ^8.0.4 -> ^8.0.11@loopback/core: ^7.0.3 -> ^7.0.10@loopback/repository: ^8.0.3 -> ^8.0.10@loopback/rest: ^15.0.4 -> ^15.0.11lodash: ^4.17.21 -> ^4.18.1tslib: ^2.6.2 -> ^2.8.1@loopback/sequelizeandjsdomare also added as direct dependencies rather than peer dependencies.Corresponding
devDependenciesversions were aligned/bumped as well (@commitlint/cli,@commitlint/config-conventional,@loopback/core,@loopback/repository,@loopback/rest,@loopback/sequelize,@loopback/testlab), andpackage-lock.jsonwas regenerated to match.Why
@sourceloop/audit-logdeclared@sourceloop/core(and other@loopback/*packages) aspeerDependencies. In consumer monorepos where@sourceloop/coreis a local workspace package (e.g.loopback4-microservice-catalog, wherenode_modules/@sourceloop/coreis a symlink topackages/core), npm cannot reconcile that peer during dependency-tree re-resolution and fails withERESOLVE. As a result,npm audit fixcould not run at all in those consumers — it aborted before applying any remediation, blocking the normal security-fix workflow.Diagnosis in the issue confirmed the peer version range itself was correct (the workspace
@sourceloop/coreat21.0.0satisfies^21.0.0); the failure was specifically npm's resolution of a registry package's peer against a workspace-linked package, not a version mismatch. Moving these packages frompeerDependenciesto directdependenciesremoves the peer relationship entirely, so there is nothing for npm to conflict on during re-resolution, andnpm audit fixcan run to completion without--legacy-peer-deps.Changes
package.json: moved@loopback/boot,@loopback/core,@loopback/repository,@loopback/rest,@loopback/sequelize,@sourceloop/core,jsdom,lodash, andtslibfrompeerDependenciestodependenciesdevDependenciespackage-lock.jsonregenerated to reflect the dependency changesRelated issue
Fixes GH-173