Skip to content

Conversation

@jdpleiness
Copy link
Contributor

Since AMIs are no longer sized, modify naming to drop artifacts from the sizing

@jdpleiness jdpleiness requested a review from a team December 19, 2024 22:47
@jdpleiness jdpleiness enabled auto-merge (squash) December 19, 2024 22:49
@jdpleiness jdpleiness merged commit b6ba814 into main Dec 19, 2024
1 check passed
@jdpleiness jdpleiness deleted the jdp/rel/modify-ami-nameing branch December 19, 2024 23:00
@sourcegraph-release-bot

The backport to 5.11.x failed at https://github.com/sourcegraph/deploy/actions/runs/12422180985:

The process '/usr/bin/git' failed with exit code 128

To backport this PR manually, you can either:

Via the sg tool

Use the sg backport command to backport your commit to the release branch.

sg backport -r 5.11.x -p 132
Via your terminal

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.11.x 5.11.x
# Navigate to the new working tree
cd .worktrees/backport-5.11.x
# Create a new branch
git switch --create backport-132-to-5.11.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b6ba81498c5899e023153ff1d7b2b15523cff47f
# Push it to GitHub
git push --set-upstream origin backport-132-to-5.11.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.11.x

If you encouter conflict, first resolve the conflict and stage all files, then run the commands below:

git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-132-to-5.11.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.11.x
  • Follow above instructions to backport the commit.
  • Create a pull request where the base branch is 5.11.x and the compare/head branch is backport-132-to-5.11.x., click here to create the pull request.

Once the pull request has been created, please ensure the following:

  • Make sure to tag @sourcegraph/release in the pull request description.

  • kindly remove the release-blocker from this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants