Skip to content

Remove outdated, unused, isConcurrent parameter for txn creation - #2

Merged
ChrisBQu merged 1 commit into
sourcenetwork:mainfrom
ChrisBQu:main
Jul 27, 2026
Merged

Remove outdated, unused, isConcurrent parameter for txn creation#2
ChrisBQu merged 1 commit into
sourcenetwork:mainfrom
ChrisBQu:main

Conversation

@ChrisBQu

Copy link
Copy Markdown
Collaborator

Some time back, we removed the isConcurrent flag that was used for transaction creation. The C bindings were updated accordingly, so nothing is broken. However, the Java SDK still containeded the parameter, which simply did nothing. This PR removes it.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: be0c6c48-80f2-4772-93e5-f1425c5d8e34

📥 Commits

Reviewing files that changed from the base of the PR and between faaf55c and 23385da.

📒 Files selected for processing (2)
  • src/main/c/nativewrapper.c
  • src/main/java/source/defra/DefraNode.java

📝 Walkthrough

Walkthrough

The transaction creation API was updated to remove the unused concurrency flag. The Java wrapper, native declaration, and JNI implementation now accept and propagate only the read-only flag.

Changes

Transaction signature alignment

Layer / File(s) Summary
Java transaction API contract
src/main/java/source/defra/DefraNode.java
The native declaration and public transactionCreate method now accept only isReadOnly.
JNI transaction implementation
src/main/c/nativewrapper.c
The JNI method removes the unused concurrency parameter and calls CreateTransaction with the read-only flag.

Estimated code review effort: 2 (Simple) | ~10 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ChrisBQu
ChrisBQu marked this pull request as ready for review July 27, 2026 17:42
@ChrisBQu
ChrisBQu merged commit e37bc6d into sourcenetwork:main Jul 27, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant