Resolve Rust compiler warnings dynamic lod travesal#361
Merged
Conversation
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes in #344 running
npm run build:wasmlogs a few warnings from the Rust compiler. Mainly boiling down to unused variables. This PR resolves them:_last_pixel_limitargument is left in to keep the signature identical to the standardtraverse_lod_treesperformanceobject was removed entirely, as the "test time" wasn't measuring anything and the resulting value was unused anywayfiner_countandlimitshave been removed as well, since no consumer read themLeaving them in (e.g. as commented code) could simplify future testing/development, but this should be avoided. Temporarily adding them back in should be straightforward. If that ends up being a common occurrence/hindrance, using conditional compilation for them would be cleaner IMHO.