Repository navigation
Test on PHP 8.5 and 8.6 - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Original advisory blocker
The unchanged PHP 8.3/Laravel 11/Guzzle 7 job failed during composer update (exit 2), before PHPUnit: every Laravel 11 candidate was blocked by security advisories including PKSA-b41t-wbzk-9q51, PKSA-d5tc-s1qs-h781, PKSA-3r5d-mb8f-1qw9, PKSA-m5cs-t1y6-qpcs and PKSA-mdq4-51ck-6kdq.
Failure log: https://github.com/spatie/geocoder/actions/runs/42015551094/job/127205076299
The rollout coordinator explicitly authorized removing only these blocked CI combinations; no advisories were ignored.
Validation
No production code or dependency changes.
Final hosted evidence
Exact head: 2b1a180. All 25 checks succeeded (24 test jobs across push/PR plus styling); PR CLEAN/MERGEABLE, not merged.
Actual runtime: PHP 8.5.12 and PHP 8.6.0-dev (61f6bc68d0071bdd756a9b6ee548b310e2835748); PHPUnit 12.5.43. Both runtimes executed each dependency combination below, with 13 tests/28 assertions and no skips:
Push runtime/dependency/test logs: https://github.com/spatie/geocoder/actions/runs/42024374440
PR test logs: https://github.com/spatie/geocoder/actions/runs/42024382346
Styling: https://github.com/spatie/geocoder/actions/runs/42024374045
PHP 8.6/Laravel 12 reports one upstream deprecation: spl_object_hash() in Illuminate/Container/Container.php:1112. It is not suppressed. Existing Composer --no-suggest option also emits a deprecation notice. No lowest-dependency or other-OS rows existed; all existing non-Laravel-11 coverage is retained.