Skip to content

❌ In PHPCS 4.0, Config::setConfigData() is not static anymore#7

Merged
spaze merged 1 commit intomainfrom
spaze/set-config-data-nonstatic
Sep 16, 2025
Merged

❌ In PHPCS 4.0, Config::setConfigData() is not static anymore#7
spaze merged 1 commit intomainfrom
spaze/set-config-data-nonstatic

Conversation

@spaze
Copy link
Owner

@spaze spaze commented Sep 16, 2025

Note: The commit in this PR was removed from the main branch and the whole PR was replaced with #8.

@spaze spaze requested a review from Copilot September 16, 2025 23:03
@spaze spaze self-assigned this Sep 16, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the code to be compatible with PHPCS 4.0 by changing from a static method call to an instance method call for Config::setConfigData().

  • Updates method call from static to instance-based approach
  • Creates a new Config instance to call the non-static method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@spaze spaze merged commit ecb7174 into main Sep 16, 2025
20 checks passed
@spaze spaze deleted the spaze/set-config-data-nonstatic branch September 16, 2025 23:04
@spaze spaze changed the title In PHPCS 4.0, Config::setConfigData() is not static anymore ~~In PHPCS 4.0, Config::setConfigData() is not static anymore~~ Sep 17, 2025
@spaze spaze changed the title ~~In PHPCS 4.0, Config::setConfigData() is not static anymore~~ ❌ In PHPCS 4.0, Config::setConfigData() is not static anymore Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants