-
Notifications
You must be signed in to change notification settings - Fork 41
Create a new setup page #6671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create a new setup page #6671
Conversation
|
Any INSERT INTO spuserpolicy (id, resource, action, collection_id, specifyuser_id) VALUES (1, '%', '%', null, 1); |
|
NOTES:
|
63728c3 to
31211cc
Compare
Triggered by 31211cc on branch refs/heads/issue-2931-1
Triggered by 7e7735c on branch refs/heads/issue-2931-1
…to issue-2931-1
Apply patches
Triggered by 86f866a on branch refs/heads/issue-2931-1
|
@ux-testing Had to make a quick fix, but this is ready for testing now 👍 |
Triggered by 41fa184 on branch refs/heads/issue-2931-1
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make sure the forms look good in light mode and dark mode (It uses your system settings.)
- You can only progress to the next form if you filled out all required fields.
- Make sure your choices are shown in the Overview sidebar.
- Make sure you can submit at the end.
- Make sure you can log into the database.
- Make sure the defaults schema config captions and descriptions appear (not blank).
- Make sure default picklists were created correctly.
- Make sure prep types were created correctly.
- Make sure all tree viewer pages load.
- Make sure the admin user's agent was created correctly. It should always have a last name.
- Make sure an empty Global Preferences file was created in App Resources.
Only tested on light mode, but since I ran into issues I figured I would request changes now.
- The Next button in the setup forms is always orange even when the a required field is empty, although it still won't let you proceed the button should be red if you can't progress.
01-07_10.53.mp4
- You can remove root nodes and create completely empty trees
- You can't see the progress bar on small screens and can't scroll either, the only way to see it is by zooming out
- Only two picklists were created by default and one is completely empty
01-07_11.56.mp4
- PrepTypes were not created at all
- Agent Type picklist was created but doesn't exist in the schema, not sure if this is related to picklists not being created or not
01-07_12.03.mp4
-
Also not sure if this is necessarily a problem with this PR or if it'll be fixed later as it's not in the testing instructions but I get this error when I open security and accounts
Specify 7 Crash Report - 2026-01-07T17_58_01.662Z.txt -
I also get this error when opening statistics
Specify 7 Crash Report - 2026-01-07T18_03_03.098Z.txt
Fix: Make root ranks required
…to issue-2931-1
Fixed. Geology was missing some defaults so those are also filled in now.
This is expected behavior for now, any tree issues will be addressed in #7593 (The tree PR already has better functionality for creating empty trees, so I will simply port that over). Tree rank configuration will also be improved then.
This may be related to the missing picklists, if it was it should be fixed now (might not be though)
These specific errors are related to missing tables in the database creation script (separate from this PR), so they will be addressed here: #7551 @specify/ux-testing So should be ready to test again 👍 |
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make sure the forms look good in light mode and dark mode (It uses your system settings.)
- You can only progress to the next form if you filled out all required fields.
- Make sure your choices are shown in the Overview sidebar.
- Make sure you can submit at the end.
- Make sure you can log into the database.
- Make sure the defaults schema config captions and descriptions appear (not blank).
- Make sure default picklists were created correctly.
- Make sure prep types were created correctly.
- Make sure all tree viewer pages load.
- Make sure the admin user's agent was created correctly. It should always have a last name.
- Make sure an empty Global Preferences file was created in App Resources.
- The overview looks incorrect on the taxon tree setup page, the bottom is cut off and you have to scroll more
01-07_13.34.mp4
- When clicking the Create button, it will load for a second then take me back to the setup and says an error occurred, after some time I have to refresh and then it takes me to the login page.
01-07_14.06.mp4
- I checked main and Agent Type doesn't have the pick list selected in schema there either so it seems like it's not an issue
- Several picklists have size limits that are set to 100 (or just generally a much higher number than items in the picklist) when there is only a handful of items and one has a size limit lower than the amount of items in the pick list, is this expected?
- COType picklist is invalid
- Agent does not have last name if you do not enter one in
Fix: overview table height
Triggered by 4e05e20 on branch refs/heads/issue-2931-1

Fixes #2931
Fixes #4832
Fixes #6210
Adds an initial set up page for configuring your database much like the Spwizard for Specify 6.
TODO:
Details
specifyuser_spprincipaltable needs to exist before the setup process works on a new sp7 database.It also looks like the admin user isn't actually a proper admin.(fixed)Future TODO:
Details
Checklist
self-explanatory (or properly documented)
Testing instructions