Assorted test fixes #412
Open
Assorted test fixes #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some doc examples in this crate that were dependent on the "serde" feature, which is not enabled by default. This change wraps problematic pieces into conditional blocks.
Contributor
Author
|
(see commit messages for explanations of the changes) |
…...) guards Package specta-tests doesn't define any features, so anything guarded by `#[cfg(feature = "zzz")` is excluded. When the tests were moved from the specta package in specta-rs#247 these guards were accidentally left in place. This change removes some of these guards and makes these tests unconditional. Now such tests are included unconditionally. I think this is better than adding corresponding features to the test package. Unlike the library package, we don't care that much about it being lightweight, and there is value in running the tests always. It doesn't remove all of the problematic feature guards because I've lost steam halfway through. I've marked the remaining guards with TODOs.
This file is not part of the source tree. There is another file tests/tests/json.rs which is. It mostly has the same content, but just in case I moved unique parts from the stray back to the "proper" json.rs.
The fact that Box<> is transparent to specta is already tested in https://github.com/specta-rs/specta/blob/8095af4205453c7b9f75ebe15ad1ad5fa02eb95a/tests/tests/ts_rs/nested.rs#L17 and in https://github.com/specta-rs/specta/blob/8095af4205453c7b9f75ebe15ad1ad5fa02eb95a/tests/tests/recursive.rs#L12 And it has nothing to do with generics.
Vlad-Shcherbina
force-pushed
the
more-test-fixes
branch
from
25d92df to
651f20c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo test -p specta-typescript(without--all-features)