lnpeer: deduct jit channel fees from total amount #10348
Merged
+23
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f321x
force-pushed
the
fix_jit_channel_openings_regtest
branch
from
48ca037 to
b244b68
Compare
Deduct the just in time channel opening fees from the total amount so htlcs don't get timed out if they come from a just in time channel with opening fee. Related: spesmilo#9584
ecdsa
reviewed
Dec 6, 2025
electrum/lnpeer.py
Outdated
|
|
||
| if trampoline_payment_key and trampoline_payment_key != payment_key: | ||
| # first stage of trampoline payment, the first stage must never get set COMPLETE | ||
| if amount_msat >= any_trampoline_onion.amt_to_forward: |
Member
There was a problem hiding this comment.
this probably requires the same change as below?
- if amount_msat >= any_trampoline_onion.amt_to_forward:
+ if amount_msat >= (any_trampoline_onion.amt_to_forward - jit_opening_fees_msat):
ecdsa
force-pushed
the
fix_jit_channel_openings_regtest
branch
from
b244b68 to
da99815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduct the just in time channel opening fees from a htlc sets total amount so htlcs don't get timed out if they come from a just in time channel with opening fee.
Fixes the regtest on master, howevertrampoline paymentsmightneed some additional changes.Related: #9584