Skip to content

Add missing domain methods#99

Open
BrennanGit wants to merge 2 commits into
sphinx-doc:mainfrom
BrennanGit:bugfix/missing-domain-methods
Open

Add missing domain methods#99
BrennanGit wants to merge 2 commits into
sphinx-doc:mainfrom
BrennanGit:bugfix/missing-domain-methods

Conversation

@BrennanGit

Copy link
Copy Markdown

This PR adds some missing methods to the new domain introduced in v0.6.0.
We were seeing that not having merge_domaindata implemented was causing our parallel sphinx builds to fail.

note: adding a failing test first to demonstrate the fix works

Resolves #98

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.71%. Comparing base (f918d4e) to head (d394791).

Files with missing lines Patch % Lines
sphinxarg/ext.py 61.11% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   50.15%   50.71%   +0.56%     
==========================================
  Files          18       19       +1     
  Lines        1292     1321      +29     
  Branches      262      269       +7     
==========================================
+ Hits          648      670      +22     
- Misses        600      605       +5     
- Partials       44       46       +2     
Flag Coverage Δ
unittests 50.49% <75.86%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BrennanGit

Copy link
Copy Markdown
Author

Hi, just bumping this as I'm being asked by my team to hard-pin sphinx-argparse to the previous version until its resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel build fails with sphinx-argparse v0.6.0

1 participant