feat: simplify policy identification by using name as primary identif…#284
Open
Aliexe-code wants to merge 1 commit intospiffe:mainfrom
Open
feat: simplify policy identification by using name as primary identif…#284Aliexe-code wants to merge 1 commit intospiffe:mainfrom
Aliexe-code wants to merge 1 commit intospiffe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the auto-generated UUID ID field from SPIKE policies and uses the user-provided name as the sole unique identifier, aligning with HashiCorp Vault's approach for better UX and simplicity.
Problem
SPIKE policies had two identifiers:
Testing
All existing tests pass
Build succeeds
No breaking changes to existing behavior (IDs are internal only)
This change is backward compatible for end users since they always used name in CLI commands. The ID field was only used internally and never exposed to users in the API responses of these endpoints.⚠️
Follow-up Required
SDK Dependency: The spike-sdk-go package contains request/response structs that still use ID fields. This PR includes a temporary workaround using the SDK's ID field but treating it as the policy name. A follow-up PR to the SDK is needed to:
Rename PolicyReadRequest.ID to PolicyReadRequest.Name
Rename PolicyDeleteRequest.ID to PolicyDeleteRequest.Name
Update PolicyListItem.ID to be consistent
issue Simplify policy identification: use name as primary identifier; remove ID from policies #250