Repository navigation
Preserve child exit status during restart - #4
Merged
Merged
Conversation
Startup detaches the child while shutdown separately waits for the same PID. If shutdown reaps it first, the detached waiter returns nil and exit mode crashes when checking success?. Share the detached waiter between both paths so only one thread collects the exit status. Keep signal timeouts and escalation intact. Add a regression spec for the lost-status race and document the fix in the changelog and fork history. Docker tests pass with 101 examples, no failures, and five existing pending specs. Also verify 100 real-child shutdowns and TERM-to-KILL escalation with the exit status retained. Fixes #1
dentarg
force-pushed
the
fix/exit-status-race
branch
from
September 13, 2026 23:19
8c4c403 to
f36db09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startup detaches the child while shutdown separately waits for the same PID. If shutdown reaps it first, the detached waiter returns nil and exit mode crashes when checking success?. Share the detached waiter between both paths so only one thread collects the exit status.
Keep signal timeouts and escalation intact. Add a regression spec for the lost-status race and document the fix in the changelog and fork history.
Docker tests pass with 101 examples, no failures, and five existing pending specs. Also verify 100 real-child shutdowns and TERM-to-KILL escalation with the exit status retained.
Fixes #1