Fix: manage v3 secret from docker entrypoint #1271
Conversation
cwadhwani-splunk
force-pushed
the
fix/manage_v3_secret_from_docker_entrypoint
branch
from
83b7a51 to
c4c8a89
Compare
omrozowicz-splunk
left a comment
omrozowicz-splunk
left a comment
There was a problem hiding this comment.
this approach indeed looks easier, but I'm wondering what would be the consequence if they run it with the previously generated secrets? is there any option to smooth it out?
| From SC4SNMP 1.15.0, this process has been simplified and can manage all SNMPv3 secrets using a single secrets.json file. | ||
|
|
||
| #### 1. For setups not yet migrated to latest version | ||
| First, delete all existing secrets from docker-compose.yaml using manage_secrets.py with the following flags: |
There was a problem hiding this comment.
will it fail if the user won't do it? I'm afraid nobody's reading the documentation 😂
There was a problem hiding this comment.
No, it will not fail. Just the undeleted secrets will still be present as secrets inside the container.
There was a problem hiding this comment.
ok and if somebody migrate to the newest version (both package and images) they need to go through the process of secret creation once again?
There was a problem hiding this comment.
yes need to create again, as they would have to upgrade the containers after migration.
2 participants
Description
Handled the creation and deletion of secrets from docker entrypoint using json file, instead of executing manage_secrets.py for each secrets before installation.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally
Checklist