fix: SimpleVectorStoreFilterExpressionConverter incorrectly treats "in" substring inside metadata key as IN operator #4909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a substring–based bug in SimpleVectorStoreFilterExpressionConverter where metadata keys containing "in" were incorrectly interpreted as IN operators.
The fix ensures that only real IN / NOT IN operators trigger the contains() conversion logic.
Changes
Updated doValue() to detect true IN operators using more precise checks:
Closes: #4908