Fix Advisor NPEs by enforcing non-null context in ChatClientRequest/Response #4953
+73
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4952
Approach
ChatClientRequest.ChatClientResponsefor consistency, so direct response creation can’t sneak in nulls.Map.copyOfsafely.Scope
ChatClientRequest: constructor/builder enforce non-null keys and values (including single key/value adder).ChatClientResponse: constructor/builder enforce non-null keys and values for symmetry.IllegalArgumentException.IllegalArgumentException.Test plan
./mvnw -pl spring-ai-client-chat -DskipITs test(module scope).ChatClientRequestTestsandChatClientResponseTestscover null key/value rejection.Backward compatibility
nullvalues will now throwIllegalArgumentExceptionimmediately at construction time, rather than causing an NPE later in Advisors.