Skip to content

feat: add option to exclude path length #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtatheonly wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add option to exclude path length #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cmd/sign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ func NewSignCommand() cli.Command {
Value: 0,
Usage: "Maximum number of non-self-issued intermediate certificates that may follow this CA certificate in a valid certification path",
},
cli.BoolFlag{
Name: "exclude-path-length",
Usage: "Exclude 'Path Length Constraint' from this CA certificate",
},
},
Action: newSignAction,
}
Expand Down Expand Up @@ -142,12 +146,17 @@ func newSignAction(c *cli.Context) {
}
}

if c.IsSet("path-length") && c.IsSet("exclude-path-length") {
fmt.Fprintf(os.Stderr, "The \"path-length\" and \"exclude-path-length\" flags cannot be used together!\n")
os.Exit(1)
}

var crtOut *pkix.Certificate
if c.Bool("intermediate") {
fmt.Fprintln(os.Stderr, "Building intermediate")

opts := []pkix.Option{
pkix.WithPathlenOption(c.Int("path-length"), false),
pkix.WithPathlenOption(c.Int("path-length"), c.Bool("exclude-path-length")),
}

crtOut, err = pkix.CreateIntermediateCertificateAuthorityWithOptions(crt, key, csr, expiresTime, opts...)
Expand Down