feat: add variadic argument support to CLI targets#2
Open
Conversation
Detect *ast.Ellipsis in funcType() to accept variadic parameters as targets. Add IsVariadic to Function struct. ExecCode() generates slice-consuming code for the variadic arg and spreads it at the call site.
Use IsVariadic on Function to compute a minimum arg count (len(Args)-1) instead of an exact count, allowing the variadic slice to be empty. Error messages distinguish 'expected at least N' for variadic targets.
Add Greet(...string) and Tag(string, ...string) to the args testdata magefile. Add five integration tests covering zero variadic args, one arg, multiple args, missing required prefix, and mixed required+variadic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends mage target invocation to support variadic parameters (e.g.
func Deploy(env string, flags ...string)). Previously such functions were silently skipped by the parser.parse/parse.go: detect*ast.EllipsisinfuncType(), addIsVariadictoFunction, generate slice-consuming code inExecCode()mage/template.go: uselen(Args)-1minimum arg count for variadic targets; conditionalize error message wordingGreet(...string)andTag(string, ...string)testdata targets; five new integration testsmg.F()variadic support (added in magefile#402) is unaffected.