Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Oct 22, 2024

Description

Part of: stackabletech/issues#211

Actually it still stops reconciling if an authentication class is invalid. Not sure if that check can be removed now.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [x] Changelog updated
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan self-assigned this Oct 22, 2024
@razvan razvan requested a review from a team October 22, 2024 11:12
@razvan razvan requested a review from nightkr October 22, 2024 12:34
@razvan razvan enabled auto-merge October 22, 2024 13:24
@razvan razvan added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 4b8f2db Oct 22, 2024
30 checks passed
@razvan razvan deleted the feature/deserializeguard branch October 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants