Support configuring components when installing flux #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timebertt
reviewed
Dec 5, 2025
| # name: flux-system | ||
| url: https://github.com/fluxcd/flux2-kustomize-helm-example | ||
| # secretResourceName: flux-ssh-secret | ||
| # secretResourceName: flux-ssh-secret |
Member
There was a problem hiding this comment.
Isn't this a field within source?
Comment on lines
+39
to
+41
| # additionalSecretResources: | ||
| # - name: shoot-vault-secret | ||
| # targetName: vault |
| version: v2.1.2 # defaults to some current version, not latest! | ||
| registry: ghcr.io/fluxcd | ||
| namespace: flux-system | ||
| componentsExtra: |
Member
There was a problem hiding this comment.
Can you add an example for components as well?
|
|
||
| // Components allows overwriting the components that should be installed. | ||
| // See https://fluxcd.io/flux/installation/configuration/optional-components/ for a list of default | ||
| // components. The minimum required components are: source-controller,kustomize-controller |
Member
There was a problem hiding this comment.
Should we validate the minimum required components are specified?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Adds options for configuring components when installing flux. With this you can for example enable the new
source-watcheror remove thenotifications-controller.Special notes for your reviewer:
/cc @timebertt