ROX-30302: implement heap profiler #101
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new heap profiler is based on jemalloc and directly handled on the endpoints module. The implementation is not complete and requires we replace the allocator we use with jemalloc which has been archived a few months ago, so we still need to have a talk with the wider team to decide whether this is something we want to pursue. For cleanness, the feature is behind a compile time feature, so if we decide to go with this implementation, we can at least decide when we want to replace the default allocator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new heap profiler is based on jemalloc and directly handled on the endpoints module. The implementation is not complete and requires we replace the allocator we use with jemalloc which has been archived a few months ago, so we still need to have a talk with the wider team to decide whether this is something we want to pursue.
For cleanness, the feature is behind a compile time feature, so if we decide to go with this implementation, we can at least decide when we want to replace the default allocator.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Manually tested.