ROX-31434: Add node to file system events #147
Conversation
.gitmodules
Outdated
| path = third_party/stackrox | ||
| url = https://github.com/stackrox/stackrox | ||
| branch = master | ||
| branch = jv-ROX-31434-enrich-file-system-events-with-node-details |
There was a problem hiding this comment.
First the branch listed above will be merged in stackrox/stackrox. Then this can be changed to master. Then this PR can be merged.
There was a problem hiding this comment.
Can you list the PR associated with the branch so we can look at the changes in there in a simpler way?
There was a problem hiding this comment.
The PR associated with this branch is this one https://issues.redhat.com/browse/ROX-31753
There was a problem hiding this comment.
That is an issue, I was referring to the PR in the stackrox/stackrox repo
I guess I'll find it by searching the issue number...
There was a problem hiding this comment.
This has now been changed back to master.
Molter73
left a comment
Molter73
left a comment
There was a problem hiding this comment.
Change LGTM, but as stated in one of your comments, we need to get the new branch in the main repo merged to master before I can approve.
.gitmodules
Outdated
| path = third_party/stackrox | ||
| url = https://github.com/stackrox/stackrox | ||
| branch = master | ||
| branch = jv-ROX-31434-enrich-file-system-events-with-node-details |
There was a problem hiding this comment.
Can you list the PR associated with the branch so we can look at the changes in there in a simpler way?
|
/retest |
Molter73
left a comment
Molter73
left a comment
There was a problem hiding this comment.
LGTM! Thanks for driving this one @JoukoVirtanen!
JoukoVirtanen
deleted the
jv-ROX-31434-add-node-to-file-system-events
branch
2 participants
Description
Makes it so that the node is reported for fact events. The node name is added to the protobuf definition for fact messages here stackrox/stackrox#17792. That PR also enriches events from fact with node information.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Testing was performed here stackrox/stackrox#17792 and shows that the node name is sent. Unfortunately it is obtained from the fact containers
etcorprocdirectory instead of its hosts. That can be fixed in a different PR.