Skip to content

Conversation

@jvdm
Copy link
Contributor

@jvdm jvdm commented Dec 10, 2025

Summary

Backport of #2491 to release-2.36.

  • Skip feature-level FixedBy assertions in E2E tests to eliminate frequent test failures when new advisories are published
  • Per-vulnerability FixedBy validation is preserved, which is more stable and meaningful

Test plan

  • E2E tests pass

The feature-level FixedBy field changes every time a new advisory is
published for a package. This causes frequent E2E test failures that
require manual updates to the test assertions.

Analysis of git history shows that ~74% of commits to testcase_test.go
are updates to FixedBy values - maintenance overhead with minimal test
value since:

1. Per-vulnerability FixedBy is still validated (stable, per-RHSA)
2. Vulnerability detection (correct CVEs/RHSAs) is still tested
3. CVSS metadata (scores, vectors) is still tested
4. Feature identification (name, version, namespace) is still tested

This change mirrors the approach already used in grpc_test.go which
clears FixedBy before comparison.
@jvdm jvdm requested a review from a team as a code owner December 10, 2025 03:05
@jvdm jvdm merged commit cf2d3e8 into release-2.36 Dec 10, 2025
39 checks passed
@jvdm jvdm deleted the jvdm/skip-fixedby-e2e-check-2.36 branch December 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants