Repository navigation
Conversation
3 of 4 tasks
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
This was referenced Oct 23, 2026
Defer MCP context setup and handle request, schema, and provider setup failures at one shared boundary. Known non-security Data API errors keep their codes and messages. Unexpected setup failures return a generic error. Authentication, security, protocol, cancellation, and processor failures keep their existing handling. Rebased onto fix/mcp-request-context-cleanup without the readable-results change. Tool results keep empty text content, so the tests check structuredContent and _meta instead.
erichare
force-pushed
the
fix/mcp-setup-errors
branch
from
October 27, 2026 23:08
71765e2 to
81ed051
Compare
erichare
changed the base branch from
fix/mcp-readable-results
to
fix/mcp-request-context-cleanup
October 27, 2026 23:11
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Defers MCP context setup and handles request, schema, and provider setup failures at one shared boundary. Known non-security Data API errors keep their codes and messages, while unexpected setup failures return a generic error. Authentication/security, protocol, cancellation, and processor failures keep their existing handling.
This builds on #2645. It no longer depends on #2652, so tool results keep empty text content and the tests check
structuredContentand_metainstead.Which issue(s) this PR fixes:
Fixes #2628. OAuth admission remains in #2642.
Verification
39 focused tests passed with 0 failures, 0 errors, and 0 skips on commit
81ed051ae. The formatter check also passed in the same invocation.McpSetupErrorsIntegrationTestpassed 6 of 6 against a packaged build.Manual client checks were not run.
Checklist