Repository navigation
Conversation
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
3 of 4 tasks
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
This was referenced Oct 23, 2026
Rebased onto fix/mcp-tool-behavior-hints without the readable-results change. Tool results keep empty text content, so McpCommandValidationTest checks structuredContent for errors and _meta status against the HTTP response.
erichare
force-pushed
the
fix/mcp-command-validation
branch
from
October 27, 2026 23:54
3f3c436 to
1a9abb5
Compare
Tool results keep empty text content now that the readable-results change is dropped. Data and errors are in structuredContent, and status stays in _meta.status.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Applies the existing command validation before MCP schema lookup or execution. Empty and oversized insert batches and invalid find options return the same error code and reason as HTTP. Both transports use one error mapper.
Adds an MCP guide covering the endpoint, results, and command validation. This builds on #2649.
Which issue(s) this PR fixes:
Fixes #2632.
Verification
45 focused tests passed with 0 failures, 0 errors, and 0 skips on commit
0d6443e4b, and formatting checks passed. That is one fewer than before because the serialization-failure logging test left with #2652. The MCP integration suite passed 66 of 66 atfc715181f, which has the same code as the current stack apart from the results guide fix.Manual client checks were not run.
Checklist