Skip to content

apollo_consensus_orchestrator: test transactions with proofs in validate_proof#12367

Open
einat-starkware wants to merge 1 commit intomain-v0.14.2from
einat/transaction_converter/test_verify_in_consensus
Open

apollo_consensus_orchestrator: test transactions with proofs in validate_proof#12367
einat-starkware wants to merge 1 commit intomain-v0.14.2from
einat/transaction_converter/test_verify_in_consensus

Conversation

@einat-starkware
Copy link
Contributor

@einat-starkware einat-starkware commented Feb 8, 2026

Note

Low Risk
Test-only changes that expand coverage for proof-verification failure handling without modifying production validation logic.

Overview
Adds a new validate_proposal regression test that simulates client-side proof verification failures by returning a VerifyAndStoreProofTask that errors, and asserts the validator aborts the proposal and surfaces ValidateProposalError::ProposalPartFailed with the verification message.

Minor test cleanup removes outdated TODO comments in test_utils around client-side proving/verification handles.

Written by Cursor Bugbot for commit 8c25666. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

@einat-starkware einat-starkware marked this pull request as ready for review February 8, 2026 13:24
@einat-starkware einat-starkware force-pushed the einat/transaction_converter/test_verify_in_consensus branch from 6d8256c to f953d56 Compare February 9, 2026 13:57
@einat-starkware einat-starkware force-pushed the einat/transaction_converter/async_verify_in_consensus branch from 3e62795 to 06288c5 Compare February 9, 2026 13:57
@einat-starkware einat-starkware force-pushed the einat/transaction_converter/test_verify_in_consensus branch 2 times, most recently from 59f92de to cb9de4a Compare February 12, 2026 09:54
@einat-starkware einat-starkware force-pushed the einat/transaction_converter/async_verify_in_consensus branch from 06288c5 to 8820a22 Compare February 12, 2026 09:54
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@einat-starkware einat-starkware changed the base branch from einat/transaction_converter/async_verify_in_consensus to graphite-base/12367 February 12, 2026 10:21
@einat-starkware einat-starkware force-pushed the einat/transaction_converter/test_verify_in_consensus branch from cb9de4a to 229599e Compare February 25, 2026 10:23
@einat-starkware einat-starkware changed the base branch from graphite-base/12367 to main-v0.14.2 February 25, 2026 10:23
@einat-starkware einat-starkware force-pushed the einat/transaction_converter/test_verify_in_consensus branch from 229599e to 8c25666 Compare March 9, 2026 09:31
@einat-starkware einat-starkware requested a review from noaov1 March 9, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants