apollo_consensus_orchestrator: test transactions with proofs in validate_proof#12367
Open
einat-starkware wants to merge 1 commit intomain-v0.14.2from
Open
apollo_consensus_orchestrator: test transactions with proofs in validate_proof#12367einat-starkware wants to merge 1 commit intomain-v0.14.2from
einat-starkware wants to merge 1 commit intomain-v0.14.2from
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6d8256c to
f953d56
Compare
3e62795 to
06288c5
Compare
59f92de to
cb9de4a
Compare
06288c5 to
8820a22
Compare
crates/apollo_consensus_orchestrator/src/validate_proposal_test.rs
Outdated
Show resolved
Hide resolved
8820a22 to
a0f3ab6
Compare
cb9de4a to
229599e
Compare
229599e to
8c25666
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Test-only changes that expand coverage for proof-verification failure handling without modifying production validation logic.
Overview
Adds a new
validate_proposalregression test that simulates client-side proof verification failures by returning aVerifyAndStoreProofTaskthat errors, and asserts the validator aborts the proposal and surfacesValidateProposalError::ProposalPartFailedwith the verification message.Minor test cleanup removes outdated TODO comments in
test_utilsaround client-side proving/verification handles.Written by Cursor Bugbot for commit 8c25666. This will update automatically on new commits. Configure here.