Skip to content

apollo_consensus: replace numbers with consts in StreamHandler tests#13031

Open
guy-starkware wants to merge 1 commit intoguyn/streams/lru_alertsfrom
guyn/streams/convenience_consts
Open

apollo_consensus: replace numbers with consts in StreamHandler tests#13031
guy-starkware wants to merge 1 commit intoguyn/streams/lru_alertsfrom
guyn/streams/convenience_consts

Conversation

@guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Mar 4, 2026

Note

Low Risk
Test-only refactor with no production logic changes; risk is limited to potential minor test expectation mistakes.

Overview
Refactors stream_handler_test.rs to replace repeated 0 literals used for round/stream/message IDs with named constants (ROUND_0, STREAM_ID_0, MESSAGE_ID_0) to improve readability and reduce magic numbers in tests.

Written by Cursor Bugbot for commit 5870b36. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmaastarkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on guy-starkware).

@guy-starkware guy-starkware force-pushed the guyn/streams/convenience_consts branch from 33cb1df to 5870b36 Compare March 5, 2026 13:10
@guy-starkware guy-starkware force-pushed the guyn/streams/lru_alerts branch from 5126ff3 to 02cf221 Compare March 5, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants