apollo_consensus: replace numbers with consts in StreamHandler tests#13031
Open
guy-starkware wants to merge 1 commit intoguyn/streams/lru_alertsfrom
Open
apollo_consensus: replace numbers with consts in StreamHandler tests#13031guy-starkware wants to merge 1 commit intoguyn/streams/lru_alertsfrom
guy-starkware wants to merge 1 commit intoguyn/streams/lru_alertsfrom
Conversation
This was referenced Mar 4, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
asmaastarkware
approved these changes
Mar 5, 2026
Contributor
asmaastarkware
left a comment
There was a problem hiding this comment.
@asmaastarkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on guy-starkware).
a901a75 to
5126ff3
Compare
eebb652 to
33cb1df
Compare
33cb1df to
5870b36
Compare
5126ff3 to
02cf221
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Test-only refactor with no production logic changes; risk is limited to potential minor test expectation mistakes.
Overview
Refactors
stream_handler_test.rsto replace repeated0literals used for round/stream/message IDs with named constants (ROUND_0,STREAM_ID_0,MESSAGE_ID_0) to improve readability and reduce magic numbers in tests.Written by Cursor Bugbot for commit 5870b36. This will update automatically on new commits. Configure here.