Skip to content

Conversation

@tdupont750
Copy link

Pull request #126 changed several public methods to become async and return a Task instead of void. This change did not include the recommended naming convention of naming all async methods with the Async suffix.

In my case, this caused us to introduce a bug to a project that was using Fleck. We would ignore Task returned from IWebSocketConnection.Send, and under high load the task scheduler would get backed up.

I have updated the the public methods to include the Async suffix. However, in order to maintain backwards compatibility, I have also added obsolete methods to the interfaces without the suffix.

@artfulhacker
Copy link
Contributor

In my case, this caused us to introduce a bug to a project that was using Fleck. We would ignore Task returned from IWebSocketConnection.Send, and under high load the task scheduler would get backed up.

curious, instead of ignoring them what did you end up doing with the tasks?

@tdupont750
Copy link
Author

I believe that I used a concurrent queue and had a background task serially write messages to the connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants