fix: allow bool dtype in zeros via typed_and_generic#11627
fix: allow bool dtype in zeros via typed_and_generic#11627anandkaranubc wants to merge 1 commit intostdlib-js:developfrom
bool dtype in zeros via typed_and_generic#11627Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
CI was failing here on
This change updates zeros to use the same dtype family that includes all typed array kinds, adds a direct test for boolean zeros, and updates the docs and types so they match the behavior. Seems like zeros was meant to also support boolean values: cc: @kgryte |
|
This is the wrong fix. The actual fix is to replace the call to with a call to |
Resolves None
Description
This pull request:
booldtype inzerosviatyped_and_genericRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Normal bug identification and options to explore for fixing it.
@stdlib-js/reviewers