feat: add C implementation for math/base/special/polygamma#13419
Open
Planeshifter wants to merge 1 commit into
Open
feat: add C implementation for math/base/special/polygamma#13419Planeshifter wants to merge 1 commit into
math/base/special/polygamma#13419Planeshifter wants to merge 1 commit into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #649.
Description
This pull request:
math/base/special/polygammascripts/evalpoly.jsto also generate the compiled polynomial evaluation functions insrc/main.cRelated Issues
This pull request has the following related issues:
Questions
No.
Other
Implementation notes:
double stdlib_base_polygamma( const int32_t n, const double x ), following the integer-order convention used elsewhere (e.g.,ldexp,falling-factorial) and Boost'spolygamma(int, T). Non-integernvalidation remains on the JS side, matching existing precedent.-ffp-contract=off, with zeroNaN/Infinity/sign mismatches.n >= 13, the cotangent-polynomial table is built via a heap-allocated ping-pong buffer pair (freed before return), as rows can reach ~10⁶ doubles for reachable inputs; aNULLallocation returnsNaN.test/test.native.js(per RFC [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352) were measured accordingly, with the C and JS minima coinciding at every test site.missing_dependenciesin environments where the required native tooling is not installed.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code under my direction and guidance, including the C implementation, tests, benchmarks, and documentation. The port was adversarially reviewed and numerically validated against the existing JS implementation (bit-identical at 167,037 validation points), with all design decisions and validation results reviewed by me.
@stdlib-js/reviewers