Skip to content

style: align blas/ext/base/sreplicate metadata with sibling conventions#13424

Closed
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-commit-review-2026-07-11
Closed

style: align blas/ext/base/sreplicate metadata with sibling conventions#13424
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-commit-review-2026-07-11

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 2026-07-10 14:54 UTC-5 and 2026-07-11 12:38 UTC+5 (SHAs e713916..4da2dcf). This pull request:

blas/ext/base/sreplicate

  • Fixed blas/ext/base/sreplicate/manifest.json's dependency ordering in commit 5619c1a, which listed napi/* before strided/base/stride2offset and blas/base/shared; reordered to blas/base/sharedstrided/base/stride2offsetnapi/* to match dreplicate, sfill, and dfill.
  • In blas/ext/base/sreplicate/package.json, keywords list (commit 5619c1a) had "strided array" and "typed", neither used elsewhere in blas/ext/base, and was missing "ndarray", present in dreplicate and sfill/dfill. Removed the two stray keywords and added "ndarray" to match its siblings.

Related Issues

None.

Questions

No.

Other

Window reviewed. Seven first-parent commits on develop in the last 24 hours: two new BLAS ext-base packages (sreplicate, dreplicate), one C/native backend for math/base/special/gammaincinv, plus routine bot commits (TS declarations, TOC), a namespace-registration commit for the two new BLAS packages, and one unrelated chore: clean-up in dfirst-index-equal/sfirst-index-equal.

Validation. Four parallel reviewers ran over the union diff (two style, two bug — one Opus for each bug pass). Style pass: two findings surfaced by the BLAS-focused agent, both in blas/ext/base/sreplicate, cross-verified by re-reading manifest.json/package.json for the twin dreplicate and the reference sfill/dfill. Style pass on gammaincinv C port: no findings. Bug pass (both agents, Opus): no findings after line-by-line comparison of the ~1100-line gammaincinv/src/main.c against its JS ancestor (Chebyshev coefficients, polynomial constants, control flow, edge cases all match) and structural review of the sreplicate/dreplicate C addons (stride/offset arithmetic, argv indices, buffer bounds all correct).

Deliberately excluded. (1) One anomalous coefficient 8.04 in CK[3] of gammaincinv/src/main.c — the bug agent flagged it as visually suspicious versus its integer-valued neighbors, but the value is a faithful port from the pre-existing JS implementation and cannot be validated as wrong from the diff alone. (2) A missing trailing ; after the STDLIB_NAPI_MODULE_EXPORT_FCN_WITH_METHOD(...) invocation in dreplicate/src/addon.c: the convention is split ~162 without/~61 with across blas/ext/base, so not high-signal. (3) Any change requiring edits outside the 24h diff window.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This pull request was authored by Claude Code as a scheduled follow-up review of the last 24 hours of commits merged to develop. Reviewer agents identified deviations from sibling conventions in blas/ext/base/sreplicate; the fixes were applied mechanically to align the package with dreplicate, sfill, and dfill. Human maintainer audit expected before promotion out of draft.


@stdlib-js/reviewers


Generated by Claude Code

… conventions

Match the manifest.json `dependencies` ordering used by the twin package
`dreplicate` and by the reference `sfill`/`dfill` packages (blas/base/shared,
strided/base/stride2offset, napi/*), and align package.json keywords with the
sibling convention (add `ndarray`; drop the compound `strided array` and
`typed` keywords not used elsewhere in `blas/ext/base`).
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 11, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/sreplicate $\\color{green}383/383$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}383/383$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants