style: align blas/ext/base/sreplicate metadata with sibling conventions#13424
Closed
Planeshifter wants to merge 1 commit into
Closed
style: align blas/ext/base/sreplicate metadata with sibling conventions#13424Planeshifter wants to merge 1 commit into
blas/ext/base/sreplicate metadata with sibling conventions#13424Planeshifter wants to merge 1 commit into
Conversation
… conventions Match the manifest.json `dependencies` ordering used by the twin package `dreplicate` and by the reference `sfill`/`dfill` packages (blas/base/shared, strided/base/stride2offset, napi/*), and align package.json keywords with the sibling convention (add `ndarray`; drop the compound `strided array` and `typed` keywords not used elsewhere in `blas/ext/base`).
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-07-10 14:54 UTC-5 and 2026-07-11 12:38 UTC+5 (SHAse713916..4da2dcf). This pull request:blas/ext/base/sreplicateblas/ext/base/sreplicate/manifest.json's dependency ordering in commit 5619c1a, which listednapi/*beforestrided/base/stride2offsetandblas/base/shared; reordered toblas/base/shared→strided/base/stride2offset→napi/*to matchdreplicate,sfill, anddfill.blas/ext/base/sreplicate/package.json, keywords list (commit 5619c1a) had"strided array"and"typed", neither used elsewhere inblas/ext/base, and was missing"ndarray", present indreplicateandsfill/dfill. Removed the two stray keywords and added"ndarray"to match its siblings.Related Issues
None.
Questions
No.
Other
Window reviewed. Seven first-parent commits on
developin the last 24 hours: two new BLAS ext-base packages (sreplicate,dreplicate), one C/native backend formath/base/special/gammaincinv, plus routine bot commits (TS declarations, TOC), a namespace-registration commit for the two new BLAS packages, and one unrelatedchore: clean-upindfirst-index-equal/sfirst-index-equal.Validation. Four parallel reviewers ran over the union diff (two style, two bug — one Opus for each bug pass). Style pass: two findings surfaced by the BLAS-focused agent, both in
blas/ext/base/sreplicate, cross-verified by re-readingmanifest.json/package.jsonfor the twindreplicateand the referencesfill/dfill. Style pass ongammaincinvC port: no findings. Bug pass (both agents, Opus): no findings after line-by-line comparison of the ~1100-linegammaincinv/src/main.cagainst its JS ancestor (Chebyshev coefficients, polynomial constants, control flow, edge cases all match) and structural review of thesreplicate/dreplicateC addons (stride/offset arithmetic, argv indices, buffer bounds all correct).Deliberately excluded. (1) One anomalous coefficient
8.04inCK[3]ofgammaincinv/src/main.c— the bug agent flagged it as visually suspicious versus its integer-valued neighbors, but the value is a faithful port from the pre-existing JS implementation and cannot be validated as wrong from the diff alone. (2) A missing trailing;after theSTDLIB_NAPI_MODULE_EXPORT_FCN_WITH_METHOD(...)invocation indreplicate/src/addon.c: the convention is split ~162 without/~61 with acrossblas/ext/base, so not high-signal. (3) Any change requiring edits outside the 24h diff window.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This pull request was authored by Claude Code as a scheduled follow-up review of the last 24 hours of commits merged to
develop. Reviewer agents identified deviations from sibling conventions inblas/ext/base/sreplicate; the fixes were applied mechanically to align the package withdreplicate,sfill, anddfill. Human maintainer audit expected before promotion out of draft.@stdlib-js/reviewers
Generated by Claude Code