feat: add C implementation for `stats/base/dists/signrank/cdf` by corsairier · Pull Request #4482 · stdlib-js/stdlib

corsairier · 2025-01-02T19:42:51Z

Resolves #3883 .

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for @stdlib/stats/base/dists/signrank/cdf along with relevant tests, benchmarks and examples

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/signrank/cdf #3883

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-01-02T19:45:25Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/signrank/cdf	$\\color{green}382/382$ $\\color{green}+0.00\\%$	$\\color{green}40/40$ $\\color{green}+0.00\\%$	$\\color{green}5/5$ $\\color{green}+0.00\\%$	$\\color{green}382/382$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

corsairier · 2025-01-02T19:46:33Z

/stdlib update-copyright-years

ShabiShett07 · 2025-05-05T13:55:53Z

/stdlib merge

Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Neerajpathak07 · 2026-07-20T12:27:11Z

/stdlib update-copyright-years

The unmemoized doubly-recursive weights computation had exponential complexity, making single CDF evaluations take seconds at n~28 and effectively hang for midrange x at larger n (the JavaScript implementation memoizes and does not have this problem). Compute the weights bottom-up in O(n*x) time and O(x) space instead. Also use t.strictEqual per test conventions and fix the C example annotation. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Round into a local variable instead of mutating the parameter, matching the convention used across stats/base/dists C implementations, and compare against the support limit before casting to int to avoid overflow for huge inputs. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter

Thanks @corsairier and @Neerajpathak07!

stdlib-bot · 2026-07-22T21:48:56Z

PR Commit Message

feat: add C implementation for `stats/base/dists/signrank/cdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4482
Closes: https://github.com/stdlib-js/stdlib/issues/3883

Co-authored-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>

Please review the above commit message and make any necessary adjustments.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 2, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025

chore: update copyright years

f2de992

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025

Merge branch 'stdlib-js:develop' into clean-signrank-cdf

c7a1e84

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 5, 2025

Merge remote-tracking branch 'upstream/develop' into clean-signrank-cdf

71a2b1b

stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed bot: In Progress Pull request is currently awaiting automation. labels May 5, 2025

Merge branch 'develop' into clean-signrank-cdf

765e786

Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>

Neerajpathak07 requested a review from a team July 20, 2026 09:40

Neerajpathak07 added 2 commits July 20, 2026 17:43

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 20, 2026

chore: update copyright years

4576372

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 20, 2026

Planeshifter mentioned this pull request Jul 22, 2026

Land stats/base/dists PRs adding C implementations stdlib-js/metr-issue-tracker#1076

Closed

Planeshifter added 3 commits July 22, 2026 15:51

Planeshifter approved these changes Jul 22, 2026

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 22, 2026

stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 22, 2026

Planeshifter merged commit a82a225 into stdlib-js:develop Jul 22, 2026
31 checks passed

stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jul 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add C implementation for `stats/base/dists/signrank/cdf`#4482

feat: add C implementation for `stats/base/dists/signrank/cdf`#4482
Planeshifter merged 11 commits into
stdlib-js:developfrom
corsairier:clean-signrank-cdf

corsairier commented Jan 2, 2025

Uh oh!

stdlib-bot commented Jan 2, 2025 •

edited

Loading

Uh oh!

corsairier commented Jan 2, 2025

Uh oh!

ShabiShett07 commented May 5, 2025

Uh oh!

Neerajpathak07 commented Jul 20, 2026

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Jul 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

corsairier commented Jan 2, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

corsairier commented Jan 2, 2025

Uh oh!

ShabiShett07 commented May 5, 2025

Uh oh!

Neerajpathak07 commented Jul 20, 2026

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jul 22, 2026

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stdlib-bot commented Jan 2, 2025 •

edited

Loading