Skip to content

Add CactusLink wallet support#2097

Merged
sagpatil merged 4 commits into
mainfrom
copilot/add-cactuslink-wallet-support-2075
May 27, 2026
Merged

Add CactusLink wallet support#2097
sagpatil merged 4 commits into
mainfrom
copilot/add-cactuslink-wallet-support-2075

Conversation

@sagpatil
Copy link
Copy Markdown
Contributor

Summary

  • Upgrade @creit.tech/stellar-wallets-kit to ^2.2.0 so Laboratory can use the Cactus Link module.
  • Register CactusLinkModule in the shared wallet module list for testnet and mainnet.
  • Update the sign transaction E2E wallet modal expectation to 8 wallets and assert Cactus Link is visible.

Resolves #2075

Validation

  • pnpm lint:ts
  • pnpm exec playwright test tests/e2e/signTransactionPage.test.ts

Copilot AI review requested due to automatic review settings May 26, 2026 23:18
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX May 26, 2026
@sagpatil sagpatil requested a review from quietbits May 26, 2026 23:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Cactus Link as a supported wallet by upgrading Stellar Wallets Kit and registering the new module in the app’s wallet module list, along with updating E2E expectations for the wallet-connect modal.

Changes:

  • Upgraded @creit.tech/stellar-wallets-kit to ^2.2.0.
  • Registered CactusLinkModule in the WalletKit initialization modules list (affecting both testnet and mainnet via shared module arrays).
  • Updated the sign-transaction E2E test to expect 8 wallets and verify “Cactus Link” appears.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
package.json Bumps Stellar Wallets Kit dependency to enable Cactus Link module usage.
src/components/WalletKit/WalletKitContextProvider.tsx Adds and registers CactusLinkModule in the initialized SWK modules list.
tests/e2e/signTransactionPage.test.ts Updates wallet modal assertions for the new wallet entry.
pnpm-lock.yaml Lockfile refresh due to dependency update (includes a concerning non-registry tarball entry).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pnpm-lock.yaml Outdated
Comment thread tests/e2e/signTransactionPage.test.ts Outdated
@stellar-jenkins-ci
Copy link
Copy Markdown

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 26, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm @ethereumjs/rlp under MPL-2.0

Location: Package overview

From: pnpm-lock.yamlnpm/@creit.tech/stellar-wallets-kit@2.2.0npm/@trezor/connect-plugin-stellar@9.2.3npm/@ethereumjs/rlp@10.1.1

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@ethereumjs/rlp@10.1.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm @ethereumjs/tx under MPL-2.0

Location: Package overview

From: pnpm-lock.yamlnpm/@creit.tech/stellar-wallets-kit@2.2.0npm/@trezor/connect-plugin-stellar@9.2.3npm/@ethereumjs/tx@10.1.1

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@ethereumjs/tx@10.1.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm @ethereumjs/util under MPL-2.0

Location: Package overview

From: pnpm-lock.yamlnpm/@creit.tech/stellar-wallets-kit@2.2.0npm/@trezor/connect-plugin-stellar@9.2.3npm/@ethereumjs/util@10.1.1

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@ethereumjs/util@10.1.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm rpc-websockets under LGPL-3.0-only

Location: Package overview

From: pnpm-lock.yamlnpm/@creit.tech/stellar-wallets-kit@2.2.0npm/rpc-websockets@9.3.9

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/rpc-websockets@9.3.9. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm ua-parser-js under AGPL-3.0-or-later

License: AGPL-3.0-or-later - The applicable license policy does not permit this license (5) (npm metadata)

License: AGPL-3.0-or-later - The applicable license policy does not permit this license (5) (package/package.json)

License: AGPL-3.0-or-later - The applicable license policy does not permit this license (5) (package/LICENSE.md)

From: pnpm-lock.yamlnpm/@creit.tech/stellar-wallets-kit@2.2.0npm/@trezor/connect-plugin-stellar@9.2.3npm/ua-parser-js@2.0.10

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/ua-parser-js@2.0.10. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm usb under GPL-1.0-only

License: GPL-1.0-only - The applicable license policy does not permit this license (5) (package/libusb/examples/ezusb.h)

License: GPL-1.0-only - The applicable license policy does not permit this license (5) (package/libusb/examples/ezusb.c)

License: GPL-1.0-only - The applicable license policy does not permit this license (5) (package/libusb/examples/fxload.c)

From: pnpm-lock.yamlnpm/@creit.tech/stellar-wallets-kit@2.2.0npm/@trezor/connect-plugin-stellar@9.2.3npm/usb@2.17.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/usb@2.17.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
HTTP dependency: npm viem depends on https://pkg.pr.new/ox@386a3439fe1ce76d237930f8c6e6bb493746069a

Dependency: ox@https://pkg.pr.new/ox@386a3439fe1ce76d237930f8c6e6bb493746069a

Location: Package overview

From: pnpm-lock.yamlnpm/@creit.tech/stellar-wallets-kit@2.2.0npm/viem@2.51.0

ℹ Read more on: This package | This alert | What are http dependencies?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Publish the HTTP URL dependency to a public or private package repository and consume it from there.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/viem@2.51.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Deprecated by its maintainer: npm @swc/helpers

Reason: This version contains a decorator helper regression from swc-project/swc#11847. Please upgrade to @swc/helpers@0.5.23 or newer.

From: pnpm-lock.yamlnpm/@creit.tech/stellar-wallets-kit@2.2.0npm/@swc/helpers@0.5.22

ℹ Read more on: This package | This alert | What is a deprecated package?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@swc/helpers@0.5.22. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@stellar-jenkins-ci
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@quietbits quietbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested Wallet Kit with Freighter (Testnet) and Ledger (Mainnet).

Comment thread tests/e2e/signTransactionPage.test.ts Outdated
@stellar-jenkins-ci
Copy link
Copy Markdown

@stellar-jenkins-ci
Copy link
Copy Markdown

@sagpatil sagpatil merged commit 6c7d7f4 into main May 27, 2026
7 checks passed
@sagpatil sagpatil deleted the copilot/add-cactuslink-wallet-support-2075 branch May 27, 2026 17:09
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add CactusLink wallet support

3 participants