Warn instead of failing when the job monitor status stops advancing - #435
Merged
Merged
Conversation
A stalled monitor is worth surfacing but is not on its own evidence that catchup is stuck, so it no longer aborts the mission. Only claimed jobs with no live workers still fail it. The two signals now track separately.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the job-monitor stall handling in historyPubnetParallelCatchupV2 so that a non-advancing monitor status is surfaced via warnings instead of aborting the mission, while still failing when there are in-progress jobs and no live workers.
Changes:
- Split stall detection into two paths: fail fast on “no live workers”, but only warn on “monitor not advancing”.
- Track
monitorStuckForSecsseparately fromstalledForSecsto measure monitor-status stagnation duration.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
src/FSLibrary/MissionHistoryPubnetParallelCatchupV2.fs:467
- Once monitorStuckForSecs crosses the stall timeout, this will log a warning on every subsequent status poll while the monitor remains stuck, which can flood logs and obscure other signals. Consider throttling the warning (e.g., reset the counter after logging) so it warns periodically rather than every interval.
if monitorNotAdvancing then
monitorStuckForSecs <- monitorStuckForSecs + jobMonitorStatusCheckIntervalSecs
if monitorStuckForSecs >= jobMonitorStallTimeOutSecs then
LogWarn
sisuresh
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A stalled monitor is worth surfacing but not worth aborting the mission.