fix: account for cancelled queued backfill batches - #722
Open
ke7haav wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes cancellation accounting for queued backfill batches.
Changes:
- Marks unstarted batches explicitly and preserves cancellation errors.
- Propagates backfill task-group failures while retaining clean live-ingestion shutdowns.
- Adds cancellation regression coverage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/services/ingest_test.go |
Adapts backfill tests to the new error return. |
internal/services/ingest_backfill.go |
Records and propagates cancelled batch states. |
internal/services/ingest_backfill_test.go |
Tests queued cancellation behavior. |
internal/ingest/ingest.go |
Restricts clean cancellation exits to live ingestion. |
internal/ingest/ingest_test.go |
Tests mode-specific shutdown classification. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #721.
Pond can cancel queued task-group work without invoking the submitted closure. Those batches previously retained zero-value
BackfillResultentries, making unattempted ledger ranges appear successful.Changes
Scope
This PR is focused on #721.
It does not change ordinary processed-batch failure handling tracked by #688 or oldest-ledger cursor publication tracked by #689.
Testing
make fmtgo vet ./...golangci-lint v2.1.2The complete database-backed suite could not run locally because PostgreSQL on
127.0.0.1:5432rejected the repository’s passwordless test DSN.