use poll() instead of select() when possible#705
Open
2128506 wants to merge 2 commits intostephane:masterfrom
Open
use poll() instead of select() when possible#7052128506 wants to merge 2 commits intostephane:masterfrom
2128506 wants to merge 2 commits intostephane:masterfrom
Conversation
…instead of crashing app if socket handle is greater than FD_SETSIZE
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
|
Related to/fixes #583. |
Contributor
|
we have to get sure this does not break ESP32 compatibility on Serial Port, it seems VFS supports only select(). has to be tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently libmodbus uses select() on Linux. If socket handle is greater than FD_SETSIZE select call causes application crash due to buffer overflow. Proposed pull request uses poll() instead of select() when available as well as fails attempts to call select on sockets >= FD_SETSIZE with EBADF.
Situation with socket handle being greater that FD_SETSIZE is not uncommon for applications that keeps hundreds of connections.