Adds API to suppress echo#819
Conversation
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
6878c3d to
65b86d1
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
|
Hey guys, |
That would be great, I'm still active here and could fix any potential issues found with the PR relatively quickly. |
Several people (including myself) have come across an issue for half-duplex rs485 networks where on some hardware, the data that is transmitted is also received as the response. This of course causes issues with being able to send/receive modbus messages.
This PR adds an API call to set a flag that when enabled, will read and ignore the number of bytes written to the socket during send requests. This has been reworked/refactored from several existing PRs (one from 2011 and one from 2018).
I tested this locally against my own hardware that has this echo issue, and this PR fixes the issue I've been seeing.