(RFC-compliance: Issue834) Fix the Violation of the requirement of Unit Identifier.#835
Open
ProtocolSpecCheck wants to merge 1 commit intostephane:masterfrom
Open
(RFC-compliance: Issue834) Fix the Violation of the requirement of Unit Identifier.#835ProtocolSpecCheck wants to merge 1 commit intostephane:masterfrom
ProtocolSpecCheck wants to merge 1 commit intostephane:masterfrom
Conversation
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
Contributor
|
👎 see comments on the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We respectfully submit this pull request in order to improve the consistency between libmodbus and its specification.
We totally respect the priority: Real-world client compatibility > Theoretical RFC compliance, and are more than happy to assist in improving RFC compliance based on this foundation.
Thank you for your attention, and we look forward to your response : )