Removing "master_nodes" module variable #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* info in this table was not "per client" (like slot_cache) so it was containing a list of all master nodes of all cluster-clients ever instantiated * list was always growing (there were just appends to the table) * list of master nodes can be already obtained from the slots info already cached per client (this eliminates the need of an extra "nodes" query to redis)
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing "master_nodes" module variable b/c:
I'm missing testing for this. I could not find in the readme or anywhere how tests are run for this project. If we can add those instructions I could run existing tests and add new ones that verify what I'm actually fixing.
Thanks