Inform csharpier about the filepath of the formatted file #820
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue discovered recently when working in a project where the .editorconfig and the dotnet project was in a subfolder to the "project root" (the location I was opening nvim from)
It lets csharpier know about the location of the file its currently formatting, and that seems to be enough to have cshapier respect the editorconfig settings, like it would if you would run the tool standalone where it modifies the files in place eg;
dotnet csharpier format .The setting is documented here:
https://csharpier.com/docs/CLI#commands
repo with a demo repo of what case this solves:
https://github.com/lukashermansson/csharpier-discrepency-demo