doc: improve task_list.width description #232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Nov 24, 2023
Comment on lines
+101
to
+103
| -- Note that min_width/max_width contraints are still applied after this, so when setting | ||
| -- width outside of the default min/max range you may need to do something like: | ||
| -- min_width = 0, max_width = 0.99, width = 20 (to set a default width of 20 columns) |
Owner
There was a problem hiding this comment.
I would leave it at "Note that min_width/max_width contraints are still applied after this." Also, this portion of the file is autogenerated, so you actually need to make the changes in config.lua
overseer.nvim/lua/overseer/config.lua
Line 20 in 6f462a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me quite a while to find #16 and understand this, as it was not immediately obvious to me that min/max are still
applied if you define
width. The original description may even be suggestive thatwidthsimply overrides min/max :DThis PR is an attempt to improve the docs there!
Awesome plugin btw - took me quite a while to figure out a usage pattern that works for me, but now I'm really enjoying it!