THREE.VRController.onGamepadDisconnect needs to be called when contro… #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llers are removed. The flow of the bug goes like this: . When the controller is connected, the gamepad object is saved at this.controller[x] . then when the controller is disconnected, the saved this.controller[x] is still in your array but the object is gone (all null) . then when the controller is reconnected again, it see that both gamepads[x] and this.controller[x] are both non-null so it does not update, then goes on to consume this.controller[x] which is already stale. This change makes sure that we flush out the this.controllers array correctly.
|
This fixes our exact problem. Please merge! |
Author
|
@stewdio , can you merge this one? |
audionerd
added a commit
to wonderunit/storyboarder
that referenced
this pull request
Jun 3, 2019
audionerd
added a commit
to wonderunit/storyboarder
that referenced
this pull request
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…llers are removed.
The flow of the bug goes like this:
. When the controller is connected, the gamepad object is saved at this.controller[x]
. then when the controller is disconnected, the saved this.controller[x] is still in your array but the object is gone (all null)
. then when the controller is reconnected again, it see that both gamepads[x] and this.controller[x] are both non-null so it does not update, then goes on to consume this.controller[x] which is already stale.
This change makes sure that we flush out the this.controllers array correctly.