-
Notifications
You must be signed in to change notification settings - Fork 31
(closes #3188) Improve automatic array privatisation validation #3214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3214 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 376 376
Lines 53194 53225 +31
=======================================
+ Hits 53142 53173 +31
Misses 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@arporter This is ready for review. |
arporter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for tracking down and fixing these fairly subtle issues. Just some minor tidying required. Your update to the message about adding symbols to "explicitly_private_symbols" made me wonder whether we have this documented anywhere but we don't seem to. Really, it would go in a "how to" section or a tutorial but I don't think we currently have anything like that?
src/psyclone/tests/psyir/transformations/parallel_loop_trans_test.py
Outdated
Show resolved
Hide resolved
|
@arporter This is ready for another look.
Although the current implementation of "explictly_private_symbols" is useful in NEMO, people requested it for LFRic_atm components but was not applicable because they use region directives, not loop directives. So I will attempt to refactor/rethink it before documenting it. But I mentioned this point in #3216 |
arporter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sergi, all looks good now.
I see the integration tests were fine.
Will proceed to merge.
This fixes two problems:
I also made the NEMOv5 gcc tests check full numerical reproducibility, which needed 5 files excluded.