ENH: deploy opensearch cluster to worker cluster to collect logs #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anish-mudaraddi
force-pushed
the
add-dev-opensearch
branch
from
a1dbafd to
7e2d039
Compare
Collaborator
Author
|
This is blocked until our DNS change freeze is complete |
anish-mudaraddi
force-pushed
the
add-dev-opensearch
branch
from
7e2d039 to
abd3b4c
Compare
anish-mudaraddi
changed the title
anish-mudaraddi
force-pushed
the
add-dev-opensearch
branch
from
224724b to
d648d82
Compare
DaveW-STFC
reviewed
Nov 21, 2024
Contributor
DaveW-STFC
left a comment
DaveW-STFC
left a comment
There was a problem hiding this comment.
Added general questions on setup
DaveW-STFC
approved these changes
Nov 21, 2024
anish-mudaraddi
force-pushed
the
add-dev-opensearch
branch
from
d648d82 to
9752d4a
Compare
Collaborator
Author
|
waiting on #227 to be merged first |
anish-mudaraddi
force-pushed
the
add-dev-opensearch
branch
from
9752d4a to
5151609
Compare
Collaborator
Author
|
I'd like a second review on this |
add a test opensearch instance to run on dev worker cluster to test collecting k8s logs
add opensearch config for setting up roles and users for writing and reading logs add separate tenants for each environment so that we can setup separate RBAC policies
this storage class can be configured separately from other apps which also use longhorn on dev-worker
to match with existing domain name format for staging/prod
move opensearch secret to apps directory and change filepath to match - encrypt with worker key
anish-mudaraddi
force-pushed
the
add-dev-opensearch
branch
from
5151609 to
16cb62c
Compare
Contributor
Dmitry-Popovichev
left a comment
Dmitry-Popovichev
left a comment
There was a problem hiding this comment.
Apart from the 1 comment about indenting it LGTM, though a 3rd experienced reviewer would be recommended.
incorrect yaml when setting up roles/rolemappings fixes remove redundant roles setup distinct dev and prod user + write users for cluster envs various helm template fixups - set and use namespace properly
Collaborator
Author
|
this is now running on dev worker cluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add necessary config to setup opensearch on the dev worker cluster