Skip to content

Conversation

@RJaliliSTFC
Copy link
Contributor

Description:

Fix cluster upscale definition to actually point at a node group


Submitter:

Have you:

  • Labelled this PR, e.g. bug, deployment, enhancement ...etc.
  • A deployment can be reviewed, and merged, by a single reviewer.
  • It can only be used to deploy, change, or remove clusters based on existing patterns for staging.
  • Anything involving prod, or production facing services must use the normal 2 person review.
  • All other PR types require the usual PR process (e.g. 2 person).

Reviewer

Have you:

  • Verified this PR uses the correct label(s) based on the rules above?
  • Checked if this could affect production (e.g. a global value that's changed without an override)?
  • Tested setting this up, if it's not a deployment, to verify it can be redeployed with any documentation if appropriate?

@DavidFair DavidFair merged commit 66fcb93 into main Nov 20, 2024
2 checks passed
@DavidFair DavidFair deleted the victoria-staging branch November 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants